Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: reduce STW from ReadMemStats #38632

Merged
merged 23 commits into from
Oct 26, 2022
Merged

util: reduce STW from ReadMemStats #38632

merged 23 commits into from
Oct 26, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 25, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #38271

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wshwsh12
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2022
@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei
Copy link
Member Author

/run-build

2 similar comments
@hawkingrei
Copy link
Member Author

/run-build

@hawkingrei
Copy link
Member Author

/run-build

@XuHuaiyu
Copy link
Contributor

Does any test need to be done on this commit?

@hawkingrei hawkingrei added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2022
@hawkingrei
Copy link
Member Author

Does any test need to be done on this commit?

OK, I will. it is in the benchmark.

@wuhuizuo
Copy link
Contributor

/run-all-tests

@hawkingrei
util: reduce STW from ReadMemStats
293c760 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
util: reduce STW from ReadMemStats
bdfe67f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
util: reduce STW from ReadMemStats
ca9abaf 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
test
baf3739 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
test
19bac96 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
test
608bfa7 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
test
07876c8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
97209b2 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2022
@hawkingrei
Copy link
Member Author

/run-check-dev

@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei
update
1c2bd57 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
c1bb49c 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
ace97dc 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2022
@hawkingrei
update
a9ffb21 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/run-build

@hawkingrei
update
0885164 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
wshwsh12
wshwsh12 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 26, 2022
@xhebox
Copy link
Contributor

xhebox commented Oct 26, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0885164

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2022
@hawkingrei
Copy link
Member Author

/run-build

@hawkingrei
Copy link
Member Author

/run-check_dev_2
/run-mysql-test

@hawkingrei
Copy link
Member Author

/run-all-tests

@hawkingrei
Copy link
Member Author

/run-all-test

1 similar comment
@hawkingrei
Copy link
Member Author

/run-all-test

@hawkingrei
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit d27c706 into pingcap:master Oct 26, 2022
@hawkingrei hawkingrei deleted the mstats branch October 26, 2022 12:45
@sre-bot
Copy link
Contributor

sre-bot commented Oct 26, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [5] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 22 min Fixed
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 9 min 12 sec Fixed
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 8 min 23 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-2 ✅ all 28 tests passed 4 min 25 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-1 ✅ all 26 tests passed 4 min 25 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 19 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@xhebox xhebox xhebox approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

manage runtime.ReadMemStats to avoid stop-the-world too much
7 participants
@hawkingrei @ti-chi-bot @XuHuaiyu @wuhuizuo @xhebox @sre-bot @wshwsh12