-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgroup: get right value when cgroup set max value #38661
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-build |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
/run-all-tests |
Not have much certainty that
https://docs.kernel.org/admin-guide/cgroup-v2.html After some searching |
/run-all-tests |
It depends on the cgroup hierarchy, maybe it is better to check whether |
if cgroup is enabled, we use memory limit from cgroup, otherwise we use memory limit of physical machine |
@lance6716 fix the wrong handling when cgroup is set as the max value. |
/unhold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cb6c759
|
/run-all-tests |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
What problem does this PR solve?
Issue Number: close #38664
Problem Summary:
What is changed and how it works?
in the old code, we cannot judge the container when it is in the docker compose.
Check List
Tests
test in the docker by @amyangfei
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.