plan, expression: move constant fold to NewFunction #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winkyao
reviewed
Jul 24, 2017
| FuncName: model.NewCIStr(funcName), | ||
| RetType: retType, | ||
| Function: f, | ||
| }, nil | ||
| } | ||
| return FoldConstant(sf), nil |
There was a problem hiding this comment.
If we fold Constant in here, so maybe no needs to use the recursive function FoldConstant, because the scalarFunction will have only one level here, use PlainFoldConstant is better? @hanfei1991
There was a problem hiding this comment.
We can change it step by step :)
|
What's the benefit? |
|
LGTM |
shenli
approved these changes
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the preparation of #3780
@winkyao