Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: show backfill type in admin show ddl jobs #38733

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Oct 28, 2022

What problem does this PR solve?

Issue Number: ref #35983

Problem Summary:

  • There is no way to know whether a finished ADD INDEX statement used the "ingest" way to backfill the records.
  • Support running multiple add index job with ingest way at the same time can cause the CPU usage being high. To reduce the effect to foreground workload, it is better to set a limit.

What is changed and how it works?

Before this PR:

+--------+-------------+------------+-----------+--------------+-----------+----------+-----------+---------------------+---------------------+---------------------+--------+
| JOB_ID | DB_NAME     | TABLE_NAME | JOB_TYPE  | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT | CREATE_TIME         | START_TIME          | END_TIME            | STATE  |
+--------+-------------+------------+-----------+--------------+-----------+----------+-----------+---------------------+---------------------+---------------------+--------+
|    166 | addindexlit | t          | add index | public       |       158 |      160 |         3 | 2022-10-28 22:58:22 | 2022-10-28 22:58:22 | 2022-10-28 22:58:25 | synced |
|    165 | addindexlit | t          | add index | public       |       158 |      160 |         3 | 2022-10-28 22:58:21 | 2022-10-28 22:58:21 | 2022-10-28 22:58:22 | synced |
+--------+-------------+------------+-----------+--------------+-----------+----------+-----------+---------------------+---------------------+---------------------+--------+

After this PR:

+--------+-------------+------------+---------------------------+--------------+-----------+----------+-----------+---------------------+---------------------+---------------------+--------+
| JOB_ID | DB_NAME     | TABLE_NAME | JOB_TYPE                  | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT | CREATE_TIME         | START_TIME          | END_TIME            | STATE  |
+--------+-------------+------------+---------------------------+--------------+-----------+----------+-----------+---------------------+---------------------+---------------------+--------+
|    166 | addindexlit | t          | add index /* ingest */    | public       |       158 |      160 |         3 | 2022-10-28 22:58:22 | 2022-10-28 22:58:22 | 2022-10-28 22:58:25 | synced |
|    165 | addindexlit | t          | add index /* txn-merge */ | public       |       158 |      160 |         3 | 2022-10-28 22:58:21 | 2022-10-28 22:58:21 | 2022-10-28 22:58:22 | synced |
+--------+-------------+------------+---------------------------+--------------+-----------+----------+-----------+---------------------+---------------------+---------------------+--------+

The concurrent limit is set to 1 as well.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2022
@Benjamin2037 Benjamin2037 self-requested a review October 28, 2022 15:19
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2022
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need store the ingest type persist into job table or history table?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2022
@hawkingrei
Copy link
Member

/run-build

@tangenta
Copy link
Contributor Author

tangenta commented Oct 28, 2022

Do we need store the ingest type persist into job table or history table?

@Benjamin2037 The type has been persisted in job.ReorgMeta.ReorgTp : )

@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 284c272

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2022
@ti-chi-bot ti-chi-bot merged commit 6d6e9c4 into pingcap:master Oct 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 2 min 33 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 30 min Fixed
idc-jenkins-ci-tidb/integration-compatibility-test ✅ all 1 tests passed 4 min 24 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 20 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 56 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 4 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants