-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix inl_hash join performance regression because of Iterator4Slice #38741
executor: fix inl_hash join performance regression because of Iterator4Slice #38741
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
…of Iterator4Slice Signed-off-by: guo-shaoge <shaoge1994@163.com>
/rebuild |
/build |
/run-all-tests |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…tidb into fix_inl_hash_join_regression
Signed-off-by: guo-shaoge <shaoge1994@163.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8225927
|
In response to a cherrypick label: new pull request created: #38749. |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
In response to a cherrypick label: new pull request created: #38754. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: guo-shaoge shaoge1994@163.com
What problem does this PR solve?
Issue Number: close #38695
Problem Summary: For each inner row, each IndexHashJoin worker need to iterate all matched outer row to make join row. And if inner side is big table, the lock contention of
sync.Pool.Get()
will be serious.What is changed and how it works?
Each innerWorker of IndexHashJoin will have its own
rowIter
to iterate outer rows.For HashJoin, each worker will also has its own iterator.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.