Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: generate AST instead of SQL for foreign key cascade #38796

Merged
merged 16 commits into from
Nov 4, 2022
Merged

executor: generate AST instead of SQL for foreign key cascade #38796

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
825b59d
executor: use generate ast instead SQL for foreign key cascade
crazycs520 Nov 1, 2022
7fb26b0
Merge branch 'master' of https://github.com/pingcap/tidb into fk-casc…
crazycs520 Nov 1, 2022
5737e9e
fix ci lint
crazycs520 Nov 2, 2022
bec5411
Merge branch 'master' into fk-cascade-ast
crazycs520 Nov 2, 2022
9b12c4c
Merge branch 'master' into fk-cascade-ast
crazycs520 Nov 2, 2022
f95a2b9
address comment
crazycs520 Nov 3, 2022
bd435a5
add comment
crazycs520 Nov 3, 2022
da040d4
Merge branch 'master' into fk-cascade-ast
crazycs520 Nov 3, 2022
3e6d116
Merge branch 'master' into fk-cascade-ast
AilinKid Nov 3, 2022
0dd154d
address comment for eliminate ParenthesesExpr when threr are only 1 f…
crazycs520 Nov 3, 2022
afc6881
refine comment
crazycs520 Nov 3, 2022
5805661
Merge branch 'master' of https://github.com/pingcap/tidb into fk-casc…
crazycs520 Nov 3, 2022
edfde5a
Merge branch 'master' into fk-cascade-ast
AilinKid Nov 4, 2022
3391534
Merge branch 'master' into fk-cascade-ast
crazycs520 Nov 4, 2022
c45b645
make bazel_prepare
crazycs520 Nov 4, 2022
0cdb70f
Merge branch 'master' into fk-cascade-ast
crazycs520 Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 40 additions & 29 deletions executor/fktest/foreign_key_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package fk_test

import (
"bytes"
"context"
"fmt"
"strconv"
"strings"
Expand All @@ -25,10 +26,14 @@ import (

"github.com/pingcap/tidb/executor"
"github.com/pingcap/tidb/kv"
"github.com/pingcap/tidb/parser/ast"
"github.com/pingcap/tidb/parser/format"
"github.com/pingcap/tidb/parser/model"
"github.com/pingcap/tidb/parser/mysql"
plannercore "github.com/pingcap/tidb/planner/core"
"github.com/pingcap/tidb/testkit"
"github.com/pingcap/tidb/types"
"github.com/pingcap/tidb/util/sqlexec"
"github.com/stretchr/testify/require"
)

Expand Down Expand Up @@ -1248,44 +1253,50 @@ func TestForeignKeyOnDeleteCascade2(t *testing.T) {
tk.MustQuery("select count(*) from t2").Check(testkit.Rows("0"))
}

func TestForeignKeyGenerateCascadeSQL(t *testing.T) {
fk := &model.FKInfo{
Cols: []model.CIStr{model.NewCIStr("c0"), model.NewCIStr("c1")},
}
func TestForeignKeyGenerateCascadeAST(t *testing.T) {
store := testkit.CreateMockStore(t)
tk := testkit.NewTestKit(t, store)
tk.MustExec("use test;")
fkValues := [][]types.Datum{
{types.NewDatum(1), types.NewDatum("a")},
{types.NewDatum(2), types.NewDatum("b")},
}
sql, err := executor.GenCascadeDeleteSQL(model.NewCIStr("test"), model.NewCIStr("t"), model.NewCIStr(""), fk, fkValues)
require.NoError(t, err)
require.Equal(t, "DELETE FROM `test`.`t` WHERE (`c0`, `c1`) IN ((1,'a'), (2,'b'))", sql)

sql, err = executor.GenCascadeDeleteSQL(model.NewCIStr("test"), model.NewCIStr("t"), model.NewCIStr("idx"), fk, fkValues)
require.NoError(t, err)
require.Equal(t, "DELETE FROM `test`.`t` USE INDEX(`idx`) WHERE (`c0`, `c1`) IN ((1,'a'), (2,'b'))", sql)

sql, err = executor.GenCascadeSetNullSQL(model.NewCIStr("test"), model.NewCIStr("t"), model.NewCIStr(""), fk, fkValues)
require.NoError(t, err)
require.Equal(t, "UPDATE `test`.`t` SET `c0` = NULL, `c1` = NULL WHERE (`c0`, `c1`) IN ((1,'a'), (2,'b'))", sql)

sql, err = executor.GenCascadeSetNullSQL(model.NewCIStr("test"), model.NewCIStr("t"), model.NewCIStr("idx"), fk, fkValues)
require.NoError(t, err)
require.Equal(t, "UPDATE `test`.`t` USE INDEX(`idx`) SET `c0` = NULL, `c1` = NULL WHERE (`c0`, `c1`) IN ((1,'a'), (2,'b'))", sql)

cols := []*model.ColumnInfo{
{ID: 1, Name: model.NewCIStr("a"), FieldType: *types.NewFieldType(mysql.TypeLonglong)},
{ID: 2, Name: model.NewCIStr("name"), FieldType: *types.NewFieldType(mysql.TypeVarchar)},
}
restoreFn := func(stmt ast.StmtNode) string {
var sb strings.Builder
fctx := format.NewRestoreCtx(format.DefaultRestoreFlags, &sb)
err := stmt.Restore(fctx)
require.NoError(t, err)
return sb.String()
}
checkStmtFn := func(stmt ast.StmtNode, sql string) {
exec, ok := tk.Session().(sqlexec.RestrictedSQLExecutor)
require.True(t, ok)
expectedStmt, err := exec.ParseWithParams(context.Background(), sql)
require.NoError(t, err)
require.Equal(t, restoreFn(expectedStmt), restoreFn(stmt))
}
var stmt ast.StmtNode
stmt = executor.GenCascadeDeleteAST(model.NewCIStr("test"), model.NewCIStr("t2"), model.NewCIStr(""), cols, fkValues)
checkStmtFn(stmt, "delete from test.t2 where (a,name) in ((1,'a'), (2,'b'))")
stmt = executor.GenCascadeDeleteAST(model.NewCIStr("test"), model.NewCIStr("t2"), model.NewCIStr("idx"), cols, fkValues)
checkStmtFn(stmt, "delete from test.t2 use index(idx) where (a,name) in ((1,'a'), (2,'b'))")
stmt = executor.GenCascadeSetNullAST(model.NewCIStr("test"), model.NewCIStr("t2"), model.NewCIStr(""), cols, fkValues)
checkStmtFn(stmt, "update test.t2 set a = null, name = null where (a,name) in ((1,'a'), (2,'b'))")
stmt = executor.GenCascadeSetNullAST(model.NewCIStr("test"), model.NewCIStr("t2"), model.NewCIStr("idx"), cols, fkValues)
checkStmtFn(stmt, "update test.t2 use index(idx) set a = null, name = null where (a,name) in ((1,'a'), (2,'b'))")
newValue1 := []types.Datum{types.NewDatum(10), types.NewDatum("aa")}
couple := &executor.UpdatedValuesCouple{
NewValues: newValue1,
OldValuesList: fkValues,
}
sql, err = executor.GenCascadeUpdateSQL(model.NewCIStr("test"), model.NewCIStr("t"), model.NewCIStr(""), fk, couple)
require.NoError(t, err)
require.Equal(t, "UPDATE `test`.`t` SET `c0` = 10, `c1` = 'aa' WHERE (`c0`, `c1`) IN ((1,'a'), (2,'b'))", sql)

newValue2 := []types.Datum{types.NewDatum(nil), types.NewDatum(nil)}
couple.NewValues = newValue2
sql, err = executor.GenCascadeUpdateSQL(model.NewCIStr("test"), model.NewCIStr("t"), model.NewCIStr("idx"), fk, couple)
require.NoError(t, err)
require.Equal(t, "UPDATE `test`.`t` USE INDEX(`idx`) SET `c0` = NULL, `c1` = NULL WHERE (`c0`, `c1`) IN ((1,'a'), (2,'b'))", sql)
stmt = executor.GenCascadeUpdateAST(model.NewCIStr("test"), model.NewCIStr("t2"), model.NewCIStr(""), cols, couple)
checkStmtFn(stmt, "update test.t2 set a = 10, name = 'aa' where (a,name) in ((1,'a'), (2,'b'))")
stmt = executor.GenCascadeUpdateAST(model.NewCIStr("test"), model.NewCIStr("t2"), model.NewCIStr("idx"), cols, couple)
checkStmtFn(stmt, "update test.t2 use index(idx) set a = 10, name = 'aa' where (a,name) in ((1,'a'), (2,'b'))")
}

func TestForeignKeyOnDeleteSetNull(t *testing.T) {
Expand Down
Loading