Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: truncate metadata streamingly #38870

Merged
merged 8 commits into from
Nov 8, 2022
Merged

log-backup: truncate metadata streamingly #38870

merged 8 commits into from
Nov 8, 2022

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Nov 3, 2022 •
edited
Loading

Signed-off-by: Leavrth jianjun.liao@outlook.com

What problem does this PR solve?

Issue Number: close #38869 #38939 #38940

Problem Summary:
truncate metadata streamingly to avoid oom

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Leavrth
truncate metadata streamingly
b2b9191 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 3, 2022
@Leavrth
remove debug codes
1c0fbd7 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
add unit test
fed5116 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
update unit test
c475ef7 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2022
This was linked to issues Nov 7, 2022
log truncate: delete the data by mistake #38939
Closed
log truncate: cause out of memory #38940
Closed
Leavrth and others added 3 commits November 7, 2022 20:00
@Leavrth
less locked area and more unit test
b305afd 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix unit test
ba0587b 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Merge branch 'master' into truncate_iterator
8033d0c
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2022
@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8033d0c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2022
@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 8, 2022

/run-mysql-test

@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 8, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 96708ad into pingcap:master Nov 8, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 8, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38972.

@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 38, total 39 22 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 44 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 15 min Fixed
idc-jenkins-ci-tidb/sqllogic-test-2 ✅ all 28 tests passed 6 min 24 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-1 ✅ all 26 tests passed 4 min 25 sec Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 33 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 27 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Leavrth added a commit to Leavrth/tidb that referenced this pull request Nov 8, 2022
@Leavrth
log-backup: truncate metadata streamingly (pingcap#38870)
cae68c5 
close pingcap#38869, ref pingcap#38939, ref pingcap#38940
joccau
joccau reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ti-chi-bot added a commit that referenced this pull request Nov 9, 2022
@ti-chi-bot
log-backup: truncate metadata streamingly (#38870) (#38972)
d662237 
close #38869, ref #38939, ref #38940
@Leavrth Leavrth deleted the truncate_iterator branch January 30, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joccau joccau joccau left review comments

@YuJuncen YuJuncen YuJuncen approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log truncate: cause out of memory log truncate: delete the data by mistake br log truncate oom
6 participants
@Leavrth @ti-chi-bot @sre-bot @3pointer @YuJuncen @joccau