-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extension: provide more complete info in StmtEventInfo when error #38963
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 338c325
|
TiDB MergeCI notify🔴 Bad News! [3] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: close #38962
Problem Summary:
In previous implement, we are using an empty
StatementContext
when handling error statement event. But it will lost some import information like access tables info. This PR fixed it.What is changed and how it works?
TaskID
of the statement context to determine whether the context is initialized.StatementContext.Tables
still right in binary executeCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.