*: Add backfill job related tables and operations #38978
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
removed
the
needs-rebase
zimulala
force-pushed
the
zimuxia/sql
branch
2 times, most recently
from
a1539e4
to
bed74c1
Compare
zimulala
requested review from
tangenta,
hawkingrei,
Defined2014 and
xiongjiwei
| ) | ||
|
|
||
| // enableDistReorg means whether to enable dist reorg. The default is enable. | ||
| // TODO: control the behavior | ||
| var enableDistReorg = atomicutil.NewBool(false) |
There was a problem hiding this comment.
We have feature tag in the sessionctx/variable/featuretag. We can test feature when it enables and disables by controlling the feature tag. I think it may be useful for you.
| } | ||
|
|
||
| // AbbrStr returns the BackfillJob's info without the Mate info. | ||
| func (bj *BackfillJob) AbbrStr() string { |
There was a problem hiding this comment.
Since this function only shows some ID related info, we don't use String here (and we're not sure if we need this function later).
| ) | ||
|
|
||
| // enableDistReorg means whether to enable dist reorg. The default is enable. | ||
| // TODO: control the behavior | ||
| var enableDistReorg = atomicutil.NewBool(false) |
There was a problem hiding this comment.
The default is enable, I think this should be ture
|
Move it to master: #39616 |
What problem does this PR solve?
Issue Number: close #37122
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.