Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: add bazel mirror #39072

Merged
merged 8 commits into from
Jul 18, 2023
Merged

bazel: add bazel mirror #39072

merged 8 commits into from
Jul 18, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39081

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 10, 2022
@hawkingrei hawkingrei changed the title bazel: add mirror bazel: add bazel mirror Nov 11, 2022
@hawkingrei hawkingrei added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2022
@hawkingrei hawkingrei force-pushed the add_mirror branch 2 times, most recently from 89cb496 to 8b11f2a Compare November 16, 2022 05:58
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
@hawkingrei hawkingrei force-pushed the add_mirror branch 3 times, most recently from 0719d28 to e647714 Compare November 29, 2022 06:28
@hawkingrei
Copy link
Member Author

/run-build
/run-unit-test

@hawkingrei
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2022
@hawkingrei
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@hawkingrei hawkingrei force-pushed the add_mirror branch 2 times, most recently from 6bfbf9b to 6fda508 Compare December 1, 2022 12:18
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2023
@hawkingrei hawkingrei requested a review from dveeden July 18, 2023 01:12
@hawkingrei
Copy link
Member Author

/retest

bb7133
bb7133 reviewed Jul 18, 2023
View reviewed changes
cmd/mirror/starlarkutil.go Outdated Show resolved Hide resolved
@hawkingrei
Copy link
Member Author

This uses a lot of fmt.Println to output the generated configuration to stdout in the mirror, and the mirror will only be used under "make bazel_prepare", so it won't output too much and affect development.

bb7133
bb7133 reviewed Jul 18, 2023
View reviewed changes
cmd/mirror/mirror.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2023
@hawkingrei
tools: add mysql-tester for adding bazel into mysql-test
1b3fc13 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
52c73e9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
d0d8872 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
173e11b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
4bd3c22 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
remove useless
e8741a6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
e70891e 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2023
bb7133
bb7133 reviewed Jul 18, 2023
View reviewed changes
cmd/mirror/mirror.go Outdated Show resolved Hide resolved
@hawkingrei
update
beda35f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@bb7133 bb7133 added the require-LGT3 Indicates that the PR requires three LGTM. label Jul 18, 2023
bb7133
bb7133 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-14 07:46:46.615212629 +0000 UTC m=+663698.385551342: ☑️ agreed by xhebox.
  • 2023-07-18 13:29:34.181877093 +0000 UTC m=+1029865.952215805: ☑️ agreed by bb7133.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2023 •
edited
Loading

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 64aacf00b8d7db51d7afff1fd9d6e3a1a14d9f4b link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, chrysan, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bb7133,chrysan,xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 17cda10 into pingcap:master Jul 18, 2023
@hawkingrei hawkingrei deleted the add_mirror branch July 18, 2023 16:04
@hawkingrei hawkingrei restored the add_mirror branch July 19, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@chrysan chrysan chrysan approved these changes

@bb7133 bb7133 bb7133 approved these changes

@dveeden dveeden Awaiting requested review from dveeden

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. require-LGT3 Indicates that the PR requires three LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimize the download speed of bazel third-party libraries
6 participants
@hawkingrei @ti-chi-bot @bb7133 @dveeden @chrysan @xhebox