Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gogctuner: support Max/Min GOGC #39109

Merged
merged 6 commits into from
Nov 14, 2022
Merged

gogctuner: support Max/Min GOGC #39109

merged 6 commits into from
Nov 14, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 14, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #39110

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 14, 2022
@hawkingrei hawkingrei force-pushed the set_gogctuner branch 2 times, most recently from 5cae61f to 66ebe93 Compare November 14, 2022 03:29
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2022
lance6716
lance6716 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

util/gctuner/tuner_test.go:40:20: undefined: MaxGCPercent

lgtm after fixing the errors

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 14, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f78b2406fbbeed0e1e45991b11da690134c6cf11

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 14, 2022
@hawkingrei
gogctuner: support Max/Min GOGC
5ed5f1d 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
gogctuner: support Max/Min GOGC
c001c82 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
c0d59d3 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
06b355b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
595484a 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
f99e135 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 14, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f99e135

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 14, 2022
@ti-chi-bot ti-chi-bot merged commit 4dd00bc into pingcap:master Nov 14, 2022
@hawkingrei hawkingrei deleted the set_gogctuner branch November 14, 2022 08:41
@hawkingrei hawkingrei restored the set_gogctuner branch November 14, 2022 09:59
@sre-bot
Copy link
Contributor

sre-bot commented Nov 14, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 44 min New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 2, success 37, total 39 1 hr 13 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/tics-test ✅ all 1 tests passed 6 min 27 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 47 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 19 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 37 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 46 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@lance6716 lance6716 lance6716 approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support to change Max/Min gogc for gogc tuner
5 participants
@hawkingrei @ti-chi-bot @sre-bot @lance6716 @Defined2014