Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support password reuse policy #39162

Merged
merged 109 commits into from
Dec 2, 2022
Merged

Conversation

bob34007
Copy link
Contributor

@bob34007 bob34007 commented Nov 15, 2022

What problem does this PR solve?

Issue Number: ref #38937

Problem Summary:

What is changed and how it works?

the feature is the same as MySQL's .

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

 support password reuse policy like MySQL . 

keeplearning20221 and others added 5 commits November 12, 2022 10:43
	modified:   errno/errname.go
	modified:   executor/errors.go
	modified:   executor/simple.go
	modified:   executor/simple_test.go
	modified:   session/bootstrap.go
	modified:   simple.go
	modified:   simple_test.go
	modified:   ../server/http_handler_serial_test.go
	modified:   ../session/bootstrap.go
	modified:   ../session/bootstrap_test.go
	modified:   ../sessionctx/variable/tidb_vars.go
@bob34007 bob34007 requested a review from a team as a code owner November 15, 2022 09:44
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 15, 2022
keeplearning20221 and others added 7 commits November 15, 2022 17:56
	modified:   errno/errname.go
	modified:   executor/errors.go
	modified:   executor/simple.go
	modified:   executor/simple_test.go
	modified:   session/bootstrap.go
	modified:   simple.go
	modified:   simple_test.go
	modified:   ../server/http_handler_serial_test.go
	modified:   ../session/bootstrap.go
	modified:   ../session/bootstrap_test.go
	modified:   ../sessionctx/variable/tidb_vars.go
	modified:   parser/parser.go
	modified:   parser/parser.y
…o enhance_passwd

Conflicts:
	executor/infoschema_cluster_table_test.go
	executor/simple.go
	parser/parser.go
	server/http_handler_serial_test.go
	session/bootstrap.go
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022
@bob34007 bob34007 changed the title Support Password Reuse Policy *: Support Password Reuse Policy Nov 15, 2022
	modified:   executor/simple.go
	modified:   session/bootstrap.go
	modified:   session/bootstrap.go
@keeplearning20221
Copy link
Contributor

/cc cbcwestwolf

@CbcWestwolf
Copy link
Member

Please run make errdoc to pass the check_dev

@CbcWestwolf
Copy link
Member

/run-unit-test

@keeplearning20221
Copy link
Contributor

Please run make errdoc to pass the check_dev

done

@keeplearning20221
Copy link
Contributor

/cc ljun0712

@keeplearning20221
Copy link
Contributor

/run-mysql-test tidb-test=pr/2022

@ti-chi-bot
Copy link
Member

@lastincisor: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@keeplearning20221
Copy link
Contributor

/run-mysql-test tidb-test=pr/2022

@keeplearning20221
Copy link
Contributor

/run-build

@keeplearning20221
Copy link
Contributor

/run-mysql-test tidb-test=pr/2022

@keeplearning20221
Copy link
Contributor

/run-unit-test

return nil, err
}
req := recordSet.NewChunk(nil)
err = recordSet.Next(ctx, req)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to:

	var rowsNum int = 0
        err = recordSet.Next(ctx, req)
	if err == nil {
		rowsNum = req.NumRows()
	}

So that handle of err is obvious.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

executor/simple.go Outdated Show resolved Hide resolved
executor/simple.go Outdated Show resolved Hide resolved
executor/simple.go Outdated Show resolved Hide resolved
executor/simple.go Outdated Show resolved Hide resolved
executor/simple.go Outdated Show resolved Hide resolved
Co-authored-by: bb7133 <bb7133@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022
@keeplearning20221
Copy link
Contributor

/run-mysql-test tidb-test=pr/2022

	modified:   executor/simple.go
	modified:   session/bootstrap.go
	modified:   sessionctx/variable/tidb_vars.go
@keeplearning20221
Copy link
Contributor

/run-mysql-test tidb-test=pr/2022

1 similar comment
@keeplearning20221
Copy link
Contributor

/run-mysql-test tidb-test=pr/2022

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Dec 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 53eac1e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2022
@ti-chi-bot ti-chi-bot merged commit 40d1ddb into pingcap:master Dec 2, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 2, 2022

TiDB MergeCI notify

🔴 Bad News! [3] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 26 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 3, success 14, total 17 19 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 10 min Existing failure
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 41 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 32 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 29 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 3 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants