-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: use advertise addr for autoid service to expose itself #39497
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cdc525e
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #39214
Problem Summary:
What is changed and how it works?
I find the real root cause this time.
On the tidb cloud environment,
conn = net.Listen()
thenconn.Addr()
does not return the instance's real IP, it's[::]
The autoid service should not register this IP
[::]
to etcd for others to connect.Use config advertise IP to expose the service.
Check List
Tests
Trying on the cloud env.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.