executor: refactor hashjoin part6 #39531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
guo-shaoge
reviewed
Dec 1, 2022
executor/join.go
Outdated
| return | ||
| } | ||
| chk := e.ctx.GetSessionVars().GetNewChunkWithCapacity(e.buildWorker.buildSideExec.base().retFieldTypes, e.ctx.GetSessionVars().MaxChunkSize, e.ctx.GetSessionVars().MaxChunkSize, e.AllocPool) | ||
| err = Next(ctx, e.buildWorker.buildSideExec, chk) | ||
| chk := w.hashJoinCtx.sessCtx.GetSessionVars().GetNewChunkWithCapacity(w.buildSideExec.base().retFieldTypes, w.hashJoinCtx.sessCtx.GetSessionVars().MaxChunkSize, w.hashJoinCtx.sessCtx.GetSessionVars().MaxChunkSize, w.hashJoinCtx.sessCtx.GetSessionVars().ChunkPool.Alloc) |
There was a problem hiding this comment.
Make w.hashJoinCtx.sessCtx.GetSessionVars() as sessVars to avoid dup code?
wshwsh12
approved these changes
Dec 1, 2022
guo-shaoge
approved these changes
Dec 1, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: dc4e7b9
|
ti-chi-bot
added
the
status/can-merge
TiDB MergeCI notify🔴 Bad News! [3] CI still failing after this pr merged.
|
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Dec 8, 2022
This reverts commit 7dedfab.
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Dec 26, 2022
This reverts commit 7dedfab.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #39061
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.