Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix panic when upgrade from 4.0.16 to master #39538

Merged
merged 13 commits into from
Dec 1, 2022

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Dec 1, 2022

What problem does this PR solve?

Issue Number: close #39527

Problem Summary:
The bug is caused by mysql.bind_info change(add 2 column) in #39156. Generally, after create the table, we will call a function insert one row, with the schema change we add two field in the sql, but this function is also called in upgradeToVer57 (), so when update from Ver <= 57 will cause this problem.

What is changed and how it works?

Modify the sql

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Manual test

Follow the indicate from #39527 (comment),

Reproduction:

截屏2022-12-01 下午3 32 15

update from 4.0.15 to master failed

After fix

截屏2022-12-01 下午3 41 30

截屏2022-12-01 下午3 42 22

upgrade success no panic

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2022
@fzzf678 fzzf678 marked this pull request as ready for review December 1, 2022 07:50
@fzzf678 fzzf678 requested a review from a team as a code owner December 1, 2022 07:50
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3c7fd5a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@fzzf678
Copy link
Contributor Author

fzzf678 commented Dec 1, 2022

/merge

@qw4990
Copy link
Contributor

qw4990 commented Dec 1, 2022

/merge

@qw4990
Copy link
Contributor

qw4990 commented Dec 1, 2022

/merge

@fzzf678
Copy link
Contributor Author

fzzf678 commented Dec 1, 2022

/run-mysql-test

2 similar comments
@qw4990
Copy link
Contributor

qw4990 commented Dec 1, 2022

/run-mysql-test

@fzzf678
Copy link
Contributor Author

fzzf678 commented Dec 1, 2022

/run-mysql-test

@fzzf678
Copy link
Contributor Author

fzzf678 commented Dec 1, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 89e9078 into pingcap:master Dec 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 1, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 25 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 19 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 16 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 5 min 0 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 11 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 1 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 27 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 51 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 21 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@fzzf678 fzzf678 added the type/bugfix This PR fixes a bug. label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/sql-plan-management release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.0.16 upgrade to master(1130) fail
5 participants