-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix panic when upgrade from 4.0.16 to master #39538
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3c7fd5a
|
/merge |
/merge |
/merge |
/run-mysql-test |
2 similar comments
/run-mysql-test |
/run-mysql-test |
/run-unit-test |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #39527
Problem Summary:
The bug is caused by mysql.bind_info change(add 2 column) in #39156. Generally, after create the table, we will call a function insert one row, with the schema change we add two field in the sql, but this function is also called in
upgradeToVer57 ()
, so when update from Ver <= 57 will cause this problem.What is changed and how it works?
Modify the sql
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Manual test
Follow the indicate from #39527 (comment),
Reproduction:
update from 4.0.15 to master failed
After fix
upgrade success no panic