Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: change the stage of count star rewriter rule from logical to post #39555

Merged
merged 13 commits into from
Dec 2, 2022
Merged

planner: change the stage of count star rewriter rule from logical to post #39555

merged 13 commits into from
Dec 2, 2022

Conversation

elsa0520
Copy link
Contributor

@elsa0520 elsa0520 commented Dec 1, 2022

What problem does this PR solve?

Issue Number: close #37165

Problem Summary:

What is changed and how it works?

Change count star rewriter from logical rule to post phase

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 1, 2022
@elsa0520 elsa0520 marked this pull request as ready for review December 1, 2022 13:08
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 1, 2022
@elsa0520
Copy link
Contributor Author

elsa0520 commented Dec 1, 2022

/run-mysql-test tidb-test=pr/2030

winoros
winoros reviewed Dec 1, 2022
View reviewed changes
planner/core/optimizer.go Outdated Show resolved Hide resolved
@elsa0520
Copy link
Contributor Author

elsa0520 commented Dec 1, 2022

/run-mysql-test tidb-test=pr/2030

winoros
winoros reviewed Dec 1, 2022
View reviewed changes
planner/core/optimizer.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2022
@winoros winoros added the sig/planner SIG: Planner label Dec 1, 2022
@elsa0520
Copy link
Contributor Author

elsa0520 commented Dec 1, 2022

/run-mysql-test tidb-test=pr/2030

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2022
@elsa0520
Copy link
Contributor Author

elsa0520 commented Dec 1, 2022

/run-unit-test

fixdb
fixdb approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bb7133
Copy link
Member

bb7133 commented Dec 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1278671

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2022
@fixdb
Copy link
Contributor

fixdb commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

bb7133
bb7133 reviewed Dec 2, 2022
View reviewed changes
planner/core/optimizer.go

Pattern:
PhysicalAggregation: count(constant)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is a blank line? Is it expected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a typo, we can delete it in later commits.

@fixdb
Copy link
Contributor

fixdb commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

5 similar comments
@fixdb
Copy link
Contributor

fixdb commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

@fixdb
Copy link
Contributor

fixdb commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

@fixdb
Copy link
Contributor

fixdb commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

@fixdb
Copy link
Contributor

fixdb commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

@fixdb
Copy link
Contributor

fixdb commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

@elsa0520
Copy link
Contributor Author

elsa0520 commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

@elsa0520
Copy link
Contributor Author

elsa0520 commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

@elsa0520
Copy link
Contributor Author

elsa0520 commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

1 similar comment
@elsa0520
Copy link
Contributor Author

elsa0520 commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

@elsa0520
Copy link
Contributor Author

elsa0520 commented Dec 2, 2022

/run-mysql-test tidb-test=pr/2030

@ti-chi-bot ti-chi-bot merged commit 6b4739f into pingcap:master Dec 2, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 2, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 23 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 6, success 11, total 17 12 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 11 min Existing failure
idc-jenkins-ci-tidb/sqllogic-test-2 ✅ all 28 tests passed 5 min 48 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-1 ✅ all 26 tests passed 4 min 19 sec Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 38 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 4 min 27 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 59 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 10 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@AkiraXie AkiraXie mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@fixdb fixdb fixdb approved these changes

@winoros winoros winoros approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

planner: optimize the performance of SELECT count(*)
7 participants
@elsa0520 @ti-chi-bot @bb7133 @fixdb @sre-bot @winoros @AilinKid