-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: disable batch store copr when paging is enabled #39580
Conversation
Signed-off-by: you06 <you1474600@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 33aef61
|
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
Signed-off-by: you06 you1474600@gmail.com
What problem does this PR solve?
Issue Number: ref #39361
Problem Summary:
Currently, batch responses in paging response is not well handled.
What is changed and how it works?
Disable batch store copr when paging is enable. Since the store batch is aiming to solve fan out issue, and the table reader in an index lookup executor do not use paging, the batch still works for our target.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.