Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "planner: update the cost formula of IndexJoin+IndexLookup" #39704

Merged
merged 11 commits into from
Dec 7, 2022
Merged

Revert "planner: update the cost formula of IndexJoin+IndexLookup" #39704

merged 11 commits into from
Dec 7, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Dec 7, 2022

Reverts #39617

@qw4990 qw4990 added sig/planner SIG: Planner epic/cost-model the optimizer cost model labels Dec 7, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Dec 7, 2022

/run-check_dev

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 7, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Dec 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7b43792

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2022
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 7, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 7, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Dec 7, 2022

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Dec 7, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit d9af2d1 into master Dec 7, 2022
@ti-chi-bot ti-chi-bot deleted the revert-39617-model2-update branch December 7, 2022 15:14
@sre-bot
Copy link
Contributor

sre-bot commented Dec 7, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟥 failed 1, success 39, total 40 22 min New failing
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 4 min 20 sec Fixed
idc-jenkins-ci-tidb/mybatis-test ✅ all 1 tests passed 3 min 42 sec Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 20 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 31 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 42 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@chrysan chrysan chrysan approved these changes

Assignees
No one assigned
Labels
epic/cost-model the optimizer cost model release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@qw4990 @ti-chi-bot @sre-bot @chrysan @time-and-fate @Reminiscent @hawkingrei