-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add rfc for resource manage #39809
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
6445b06
to
ee3f7d6
Compare
4391bcb
to
4323f4d
Compare
## Abstract | ||
|
||
This proposes a design of how to control the usage for CPU when to do DDL operator and we want to avoid concurrent ddl | ||
affecting queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
affecting queries. | |
cause an observerable impact to database foreground workload CPU usage( eg. TP and AP workload) |
## Background | ||
|
||
Currently, TiDB DDL is not well controlled, which may cause high CPU usage when we do DDL operations. For example, we | ||
have a table with 1000 columns, and we add a column to it. It will cause high CPU usage. Concurrent DDL operations may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, add a column is general DDL, it only change table meta data, will not cause high CPU usage.
4022b94
to
ff6edfd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #39809 +/- ##
================================================
+ Coverage 73.6556% 79.7549% +6.0992%
================================================
Files 1129 3577 +2448
Lines 360017 1044333 +684316
================================================
+ Hits 265173 832907 +567734
- Misses 77743 172685 +94942
- Partials 17101 38741 +21640 |
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #41184
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.