Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add rfc for resource manage #39809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 11, 2022

What problem does this PR solve?

Issue Number: close #41184

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2022
@hawkingrei hawkingrei force-pushed the add_rfc_for_resource_manage branch from 6445b06 to ee3f7d6 Compare December 11, 2022 07:22
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2022
@hawkingrei hawkingrei added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2022
@hawkingrei hawkingrei changed the title doc: add rfc for resource manage [WIP] doc: add rfc for resource manage Dec 12, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2022
@hawkingrei hawkingrei requested a review from djshow832 December 23, 2022 08:17
@hawkingrei hawkingrei force-pushed the add_rfc_for_resource_manage branch from 4391bcb to 4323f4d Compare February 7, 2023 03:24
@hawkingrei hawkingrei changed the title [WIP] doc: add rfc for resource manage doc: add rfc for resource manage Feb 7, 2023
@ti-chi-bot ti-chi-bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Feb 7, 2023
## Abstract

This proposes a design of how to control the usage for CPU when to do DDL operator and we want to avoid concurrent ddl
affecting queries.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
affecting queries.
cause an observerable impact to database foreground workload CPU usage( eg. TP and AP workload)

## Background

Currently, TiDB DDL is not well controlled, which may cause high CPU usage when we do DDL operations. For example, we
have a table with 1000 columns, and we add a column to it. It will cause high CPU usage. Concurrent DDL operations may
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, add a column is general DDL, it only change table meta data, will not cause high CPU usage.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the add_rfc_for_resource_manage branch from 4022b94 to ff6edfd Compare February 26, 2023 07:55
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #39809 (ff6edfd) into master (1d2040a) will increase coverage by 6.0992%.
Report is 3626 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #39809        +/-   ##
================================================
+ Coverage   73.6556%   79.7549%   +6.0992%     
================================================
  Files          1129       3577      +2448     
  Lines        360017    1044333    +684316     
================================================
+ Hits         265173     832907    +567734     
- Misses        77743     172685     +94942     
- Partials      17101      38741     +21640     

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Feb 17, 2024
Copy link

tiprow bot commented Feb 27, 2024

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test ff6edfd link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Apr 9, 2024

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test ff6edfd link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add rfc to resource manage
3 participants