Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysvar: fix inconsistency in setting password validation sysvars (#39584) #39845

Merged
merged 3 commits into from
Dec 14, 2022
Merged

sysvar: fix inconsistency in setting password validation sysvars (#39584) #39845

merged 3 commits into from
Dec 14, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #39584

What problem does this PR solve?

Issue Number: ref #38928

Also merge the PR in tidb-test

Problem Summary:

Since sysvars for password validation satisfy length >= number_count + special_char_count + 2 * mixed_case_count, altering the latter 3 sysvars may also alter length

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot requested a review from a team as a code owner December 12, 2022 14:12
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 12, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 12, 2022
@CbcWestwolf
Copy link
Member

/run-mysql-test tidb-test=pr/2039

@CbcWestwolf
Copy link
Member

/run-unit-test

@CbcWestwolf
Copy link
Member

/run-mysql-test tidb-test=pr/2039
/run-unit-test

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 13, 2022
@CbcWestwolf
Copy link
Member

/run-mysql-test tidb-test=pr/2039

@CbcWestwolf
Copy link
Member

/run-mysql-test tidb-test=pr/2039

1 similar comment
@CbcWestwolf
Copy link
Member

/run-mysql-test tidb-test=pr/2039

bb7133
bb7133 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 14, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ba45f5b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2022
@ti-chi-bot ti-chi-bot merged commit c23cd80 into pingcap:release-6.5 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees

@CbcWestwolf CbcWestwolf

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @CbcWestwolf @xiongjiwei @bb7133 @sre-bot