ttl: initialize notifyStateCh in ttl job manager (#39956) #39959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/cherry-pick-not-approved
release-note-none
YangKeao
force-pushed
the
cherry-pick-39956-to-release-6.5
branch
from
37a7df8
to
5ce277b
Compare
ti-chi-bot
added
size/XS
hawkingrei
approved these changes
Dec 20, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 5ce277b
|
ti-chi-bot
added
the
status/can-merge
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #39956
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
Issue Number: close #39955
What is changed and how it works?
Initialize the
notifyStateChwhile initializing the job manager. It'll make the recycle of scan worker much faster.Using a channel with bound 1 is good enough, as the scan worker will actually be blocked by
PollTaskResult. If the manager didn't callPollTaskResult, it will not be scheduled anything.