-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl, domain: setup a customized session pool with stats collector (#40171) #40233
ttl, domain: setup a customized session pool with stats collector (#40171) #40233
Conversation
…ats collector from ttlworker Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
2 similar comments
/retest |
/retest |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
bcbbf26
to
8239759
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #40233 +/- ##
================================================
Coverage ? 73.6745%
================================================
Files ? 1084
Lines ? 347857
Branches ? 0
================================================
Hits ? 256282
Misses ? 75118
Partials ? 16457 |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
This is an automated cherry-pick of #40171
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
Issue Number: close #40109
Problem Summary:
The table stats are not updated after ttl job.
What is changed and how it works?
Construct a new session pool with stats collector attached.
The
do.sysSessionPool
cannot have stats collector attached, because the stats handler are also using the session in this session pool, which obviously should not be collected (or it will result in endless recursive).Check List
Tests
Release note