-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: skip deleting the unmatched index key on merge (#40465) #40478
ddl: skip deleting the unmatched index key on merge (#40465) #40478
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 73e469f
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/retest |
This is an automated cherry-pick of #40465
What problem does this PR solve?
Issue Number: close #40464
Problem Summary:
In write-only state, the first insert statement wrote a kv
{5->r_6}
and updates it to{5->deleted}
immediately. This operation is incorrectly applied during the merge of temp index. As a result, the index to(5, 5)
is missing.What is changed and how it works?
When TiDB merges the temp indexes, it should check whether the index to be deleted matches against the handle in the deletion marker kv. If they don't match, TiDB can skip it directly.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.