Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: need init MDL variable when GetDomain #40512

Merged
merged 2 commits into from
Jan 11, 2023
Merged

br: need init MDL variable when GetDomain #40512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5a4879
need init MDL variable when GetDomain()
joccau Jan 11, 2023
6dd6ffe
Merge branch 'master' into fix-CI-failed
ti-chi-bot Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions br/pkg/gluetidb/glue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ func (g Glue) UseOneShotSession(store kv.Storage, closeDomain bool, fn func(glue
if err != nil {
return errors.Trace(err)
}
if err = session.InitMDLVariable(store); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may init it many times, but it's ok for now.

return errors.Trace(err)
}

// because domain was created during the whole program exists.
// and it will register br info to info syncer.
// we'd better close it as soon as possible.
Expand Down