-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle: use separete ctx for initStats #40604
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
mu struct { | ||
sync.RWMutex | ||
ctx sessionctx.Context | ||
// rateMap contains the error rate delta from feedback. | ||
rateMap errorRateDeltaMap | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that rateMap
can have its own mutex, too. Maybe we can do that in the PR or in another PR, either is ok for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will change it later
/retest-required |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b9859c7
|
/retest-required |
/run-mysql-test |
1 similar comment
/run-mysql-test |
/retest-required |
@Yisaer: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #40548
Problem Summary:
What is changed and how it works?
use separete ctx for initStats in order to avoid initStats blocking server starting process
Check List
Tests
we manually insert
Sleep
ininitStats
and start client session to tidb-server. Before this pr, the client session would be blocked, after this pr, the client session can be prcessed successfully.Release note
Please refer to Release Notes Language Style Guide to write a quality release note.