Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: check the ignore-plan-cache hint in insert-stmt (#40080) #40693

Closed
wants to merge 14 commits into from
Closed

planner: check the ignore-plan-cache hint in insert-stmt (#40080) #40693

wants to merge 14 commits into from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jan 18, 2023

This is an automated cherry-pick of #40080

What problem does this PR solve?

Issue Number: close #40079, ref #39717

Problem Summary: planner: check the ignore-plan-cache hint in insert-stmt

What is changed and how it works?

planner: check the ignore-plan-cache hint in insert-stmt

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • fixdb

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2023
@qw4990 qw4990 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Jan 18, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 18, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 50e6719

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 18, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 18, 2023

/test all

2 similar comments
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 18, 2023

/test all

@qw4990
Copy link
Contributor Author

qw4990 commented Jan 18, 2023

/test all

@Ivy-YinSu
Copy link

/run-unit-test

@Ivy-YinSu
Copy link

/test unit-test

@ti-chi-bot
Copy link
Member

@qw4990: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Ivy-YinSu
Copy link

/test unit-test

1 similar comment
@Ivy-YinSu
Copy link

/test unit-test

@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jan 19, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 28, 2023

/test unit-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 28, 2023

/test unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Jan 28, 2023

/retest

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 28, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 28, 2023

/test unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Jan 28, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 339f759

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 28, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 29, 2023
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2023
@ti-chi-bot
Copy link
Member

@qw4990: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Member

@qw4990: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 339f759 link unknown /test check-dev2
idc-jenkins-ci-tidb/build 339f759 link unknown /test build
idc-jenkins-ci-tidb/mysql-test 339f759 link unknown /test mysql-test
idc-jenkins-ci-tidb/check_dev 339f759 link unknown /test check-dev
idc-jenkins-ci-tidb/unit-test 339f759 link unknown /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 30, 2023

Too many conflicts, I'll pick it manually later.

@qw4990 qw4990 closed this Mar 30, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fixdb fixdb fixdb approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/release-blocker This issue blocks a release. Please solve it ASAP. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qw4990 @ti-chi-bot @Ivy-YinSu @fixdb @AilinKid @VelocityLight