-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix the batch check for unique index (#40672) #40702
ddl: fix the batch check for unique index (#40672) #40702
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
fc45a53
to
c9b9a67
Compare
/test mysql-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c9b9a67
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/test unit-test |
This is an automated cherry-pick of #40672
What problem does this PR solve?
Issue Number: close #40592, related to #40464.
Problem Summary:
Previously, I didn't consider the
null
values for #40464. For the unique index, the null column value keys are encoded asnull_val(00)+handle
and the value is empty. However, TiDB tries to decode the handle from index value, the panic happened.What is changed and how it works?
This PR takes the null values into consideration, and refine the batch check logic by getting the original key to prevent data inconsistency.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.