-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning/parser: support STARTING BY and IGNORE n LINES #40801
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @gozssky @lichunzhu @GMHDBJD @kennytm |
@lance6716 Could you explain why we need these two configurations? Is it possible to do them outside the parser? |
I can't come up with a simple change outside parser. We need use parser to know where a line ends, and these two configurations can skip errors when find line endings. I have added some unit tests, when the skipped content contains special characters like fields delimiter it's very complex. |
Signed-off-by: lance6716 <lance6716@gmail.com>
/hold IGNORE n LINES should be able to move out of parser, let caller call |
should be replaced by #40821 |
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: ref #40499
Problem Summary:
What is changed and how it works?
Hide these configuration for lightning, only prepare for future LOAD DATA integration
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.