Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix br debug encode panic (#40880) #40891

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #40880

Signed-off-by: zhanggaoming gaoming.zhang@pingcap.com

What problem does this PR solve?

Issue Number: close #40878

Problem Summary:
The goroutinue will panic when executing br debug encode.

What is changed and how it works?

New backuppb.Schema to avoid nil pointer dereference

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Manual test

  • br backup full
  • br debug decode
  • br debug encode
  • success

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that caused: execute br debug encode panic.

Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 31, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MoCuishle28
  • fengou1

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 31, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 31, 2023
12 tasks
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. component/br This issue is related to BR of TiDB. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. and removed do-not-merge/cherry-pick-not-approved labels Jan 31, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 31, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 31, 2023
@YuJuncen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a0df92e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 31, 2023
@MoCuishle28
Copy link
Contributor

/retest

@joccau
Copy link
Member

joccau commented Jan 31, 2023

/merge

@ti-chi-bot ti-chi-bot merged commit ac6560f into pingcap:release-6.1 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/br This issue is related to BR of TiDB. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants