-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression, cmd: fix ColumnSubstitute and allow some cases to substitute (#38826) #40913
expression, cmd: fix ColumnSubstitute and allow some cases to substitute (#38826) #40913
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/hold high priority for trunk branch |
/unhold |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #40913 +/- ##
================================================
Coverage ? 73.8627%
================================================
Files ? 1083
Lines ? 349578
Branches ? 0
================================================
Hits ? 258208
Misses ? 74850
Partials ? 16520 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/merge |
@winoros: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #38826
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #38736 and close #40536
Problem Summary:
Take the case from #38736,
the first argument's collation in the like function is utf8mb4_bin, and the second is binary.
So we can't substitute the first argument(utf8mb4_bin to utf8mb4_bin) since it is weakened than binary.
If the collation and coercibility don't change, it's safe to substitute.
What is changed and how it works?
If the collation and coercibility don't change, it's safe to substitute.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.