Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Fix tidb crash on index merge reader (#40904) #40964

Merged
merged 1 commit into from
Feb 2, 2023
Merged

executor: Fix tidb crash on index merge reader (#40904) #40964

merged 1 commit into from
Feb 2, 2023

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Feb 2, 2023 •
edited
Loading

close #40877

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 2, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2023
@windtalker
Copy link
Contributor Author

/run-all-tests

yudongusa
yudongusa approved these changes Feb 2, 2023
View reviewed changes
Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@yudongusa: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

bb7133
bb7133 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2023
@bb7133
Copy link
Member

bb7133 commented Feb 2, 2023

/merge

@ti-chi-bot
Copy link
Member

@bb7133: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 2, 2023
@bb7133
Copy link
Member

bb7133 commented Feb 2, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 446148e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2023
YangKeao
YangKeao approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hawkingrei
Copy link
Member

/merge

@windtalker
Copy link
Contributor Author

/rebuild

@guo-shaoge
Copy link
Collaborator

/test build

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot merged commit 9066ef4 into pingcap:release-6.5-20230122-v6.5.0 Feb 2, 2023
@windtalker windtalker deleted the hotfix branch February 2, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yudongusa yudongusa yudongusa approved these changes

@SeaRise SeaRise SeaRise approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@YangKeao YangKeao YangKeao approved these changes

@fixdb fixdb fixdb approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@windtalker @ti-chi-bot @bb7133 @hawkingrei @guo-shaoge @fixdb @YangKeao @SeaRise @yudongusa