*: fix a timezone data race which may cause wrong row data (#41146) #41182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note
12 tasks
ti-chi-bot
added
size/L
ti-chi-bot
added
size/XL
|
@wjhuang2016 |
VelocityLight
added
cherry-pick-approved
ti-chi-bot
added
size/L
|
/retest |
2 similar comments
|
/retest |
|
/retest |
tiancaiamao
approved these changes
Mar 30, 2023
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 866cacc
|
ti-chi-bot
added
the
status/can-merge
VelocityLight
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #41146
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #40710
Problem Summary:
As mentioned in #40710, changing the timezone in the statement context may cause data race in getColDefaultValue().
What is changed and how it works?
Add an explicit timezone argument instead of changing the timezone in the statement context.
Check List
Tests
Run the test mentioned in data race in TimeZone causes data-index inconsistency #40710. since this PR completely avoids this data race, there is no need to write a unit test. And the unit test for it is meaningless.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.