executor: fix race when collecting telemetry info of batch copr #41413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: you06 <you1474600@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/invalid-title
do-not-merge/needs-triage-completed
release-note-none
Signed-off-by: you06 <you1474600@gmail.com>
tangenta
changed the title
tangenta
approved these changes
Feb 15, 2023
ti-chi-bot
added
status/LGT1
|
/check-issue-triage-complete |
hawkingrei
reviewed
Feb 15, 2023
cfzjywxk
approved these changes
Feb 15, 2023
ti-chi-bot
added
status/LGT2
Signed-off-by: you06 <you1474600@gmail.com>
hawkingrei
approved these changes
Feb 15, 2023
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 94aed09
|
ti-chi-bot
added
the
status/can-merge
blacktear23
pushed a commit
to blacktear23/tidb
that referenced
this pull request
Feb 15, 2023
ghazalfamilyusa
pushed a commit
to ghazalfamilyusa/tidb
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: you06 you1474600@gmail.com
What problem does this PR solve?
Issue Number: close #41412
Problem Summary:
What is changed and how it works?
The build function may be called concurrently when building executors on probe side, use an atomic variable to avoid data race
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.