-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txn: fix the point get data read for RC #41590
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test unit-test |
/retest-required |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b06588a
|
/cherry-pick release-6.1-20230221-v6.1.1 |
@wuhuizuo: failed to apply #41590 on top of branch "release-6.1-20230221-v6.1.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #41581
Problem Summary:
The point get read result is unexpected if RC is used with DML statements.
What is changed and how it works?
Update the
forUpdateTS
when buildinginsert/delete/update/select for update
executors, to ensure thepointGetExecutor
may use the correct timestamp to read.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.