Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: pin go1.20 #41604

Merged
merged 3 commits into from
Feb 20, 2023
Merged

*: pin go1.20 #41604

merged 3 commits into from
Feb 20, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 20, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #40969

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
*: pin go1.20
aefd583 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 20, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Feb 20, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
*: pin go1.20
7130473 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
hawkingrei commented Feb 20, 2023
View reviewed changes
util/misc.go Outdated
// return false
// }
// return true
case *tls.CertificateVerificationError:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is related with go1.20.

For a handshake failure due to a certificate verification failure, the TLS client and server now return an error of the new type CertificateVerificationError, which includes the presented certificates.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2023
@hawkingrei
use bazel image for tidb-test
f1c9434 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2023
@hawkingrei hawkingrei requested a review from xhebox February 20, 2023 11:05
bb7133
bb7133 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 20, 2023
@bb7133
Copy link
Member

bb7133 commented Feb 20, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f1c9434

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 20, 2023
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot merged commit e3896bd into pingcap:master Feb 20, 2023
@Oreoxmt Oreoxmt mentioned this pull request May 22, 2023
Merged
16 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request May 22, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@bb7133 bb7133 bb7133 approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade go 1.20
4 participants
@hawkingrei @ti-chi-bot @bb7133 @lance6716