Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metric: fix panic when status.record-db-label enable #41692

Merged
merged 3 commits into from
Feb 23, 2023
Merged

metric: fix panic when status.record-db-label enable #41692

merged 3 commits into from
Feb 23, 2023

Conversation

srstack
Copy link
Contributor

@srstack srstack commented Feb 23, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #41688

Problem Summary: meet panic when status.record-db-label enable
image

What is changed and how it works?

add nil check

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)

  • [ ]
    image

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • jackysp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2023
hawkingrei
hawkingrei reviewed Feb 23, 2023
View reviewed changes
executor/compiler.go
@@ -216,26 +216,37 @@ func getStmtDbLabel(stmtNode ast.StmtNode) map[string]struct{} {

switch x := stmtNode.(type) {
case *ast.AlterTableStmt:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tests?

Copy link
Contributor Author

@srstack srstack Feb 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a CTE statement to test the issue
https://github.com/pingcap/tidb/pull/41692/files#diff-8b7750f45b61f757e4f73dd156bf442799203de80ebd846badcc3c8addfc4017R2159

jackysp
jackysp approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2023
bb7133
bb7133 approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 23, 2023
@bb7133
Copy link
Member

bb7133 commented Feb 23, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a0f44c8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2023
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot merged commit e58e602 into pingcap:master Feb 23, 2023
@srstack srstack deleted the metric--fix-panic-when-status.record-db-label-enable branch February 23, 2023 14:09
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Feb 28, 2023
@zeminzhou @srstack
metric: fix panic when status.record-db-label enable (pingcap#41692) (p…
09da9e3 
…ingcap#273)

close pingcap#41688

Co-authored-by: Qiμ$hiЯuí <39378935+srstack@users.noreply.github.com>
@bb7133 bb7133 added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 1, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 1, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #50858.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 1, 2024
@ti-chi-bot
metric: fix panic when status.record-db-label enable (#41692) (#50858)
6dff2a8 
close #41688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meet invalid memory address or nil pointer dereference
5 participants
@srstack @ti-chi-bot @bb7133 @hawkingrei @jackysp