-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: never write untouched index values to temp index #41879
ddl: never write untouched index values to temp index #41879
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 66507d2
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #41880
Problem Summary:
Previously, for untouched temp index key, TiDB writes it to the memory buffer and never commits it to TiKV(by checking if the last byte is the uncommited flag).
#40749 introduced a new temp index value encoding: for each insertion, TiDB appends the new temp index value to the end based on the old value. As a result, the "uncommitted flag" is not the last byte anymore and the key-value will be incorrectly committed to TiKV. The encoding becomes invalid.
What is changed and how it works?
Check the untouched values before writting to the temp index. Because the untouched values is only used for speeding up the index reading, and the temp index is never visible to the users, we can skip writting a untouched value to the temp index.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.