executor: lock duplicated keys on insert-ignore & replace-nothing (#42210) #42290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
VelocityLight
added
cherry-pick-approved
cfzjywxk
requested review from
zyguan,
MyonKeminta,
you06,
ekexium and
cfzjywxk
Signed-off-by: zyguan <zhongyangguan@gmail.com>
cfzjywxk
approved these changes
Mar 29, 2023
…ap#42642) ref pingcap#28011 Signed-off-by: zyguan <zhongyangguan@gmail.com>
|
@ekexium @MyonKeminta @you06 PTAL |
ekexium
approved these changes
Mar 29, 2023
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 483ffd9
|
ti-chi-bot
added
the
status/can-merge
|
/retest |
|
/retest |
|
/test check-dev |
12 tasks
VelocityLight
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #42210
What problem does this PR solve?
Issue Number: close #42121 #40461 #28011
Problem Summary: When doing insert-ingore or replace without changes, tidb doesn't lock conflict keys properly.
What is changed and how it works?
Lock keys even when insert-ingnore meets duplicated rows or replace without changes.
Check List
Tests
Side effects
The change may introduce more lock records, which may further lead performance regression like #25659 .
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.