parser: parse error compatible #4238
Conversation
mxlxm
commented
Aug 18, 2017
mxlxm
commented
- add ParseErrorWith function to return mysql compatible parse error.
- error on unclose comment, fix Some incorrect SQLs in prepare doesn't return the parse error #3738.
mysql/const.go
Outdated
| @@ -62,6 +62,9 @@ const ( | |||
| MaxKeyParts int = 16 | |||
| ) | |||
|
|
|||
| // ErrTextLength error text length limit. | |||
| const ErrTextLength = 80 | |||
There was a problem hiding this comment.
tested with mysql:
sql prepare p from "delete from t where a=1 /*' ccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc";
and got response like:
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '/*' cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc' at line 1
only keep nearest 80 bytes.
| @@ -1551,6 +1551,8 @@ func (s *testParserSuite) TestComment(c *C) { | |||
| {"START TRANSACTION /*!40108 WITH CONSISTENT SNAPSHOT */", true}, | |||
| // for comment in query | |||
| {"/*comment*/ /*comment*/ select c /* this is a comment */ from t;", true}, | |||
| // for unclosed comment | |||
| {"delete from t where a = 7 or 1=1/*' and b = 'p'", false}, | |||
There was a problem hiding this comment.
Could you please add more tests for error messages?
| @@ -90,7 +90,7 @@ func (s *Scanner) Errors() []error { | |||
|
|
|||
| // reset resets the sql string to be scanned. | |||
| func (s *Scanner) reset(sql string) { | |||
| s.r = reader{s: sql} | |||
| s.r = reader{s: sql, p: Pos{Line: 1}} | |||
There was a problem hiding this comment.
yes, sql line counter should always start with 1.
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
/ok-to-test |
|
@zz-jason PTAL |
|
/run-all-tests |
|
/run-all-test |
|
/ok-to-test |
|
/run-all-test |
