expression: prepare `grouping` function for `roll up` #42464

xzhangxian1008 · 2023-03-22T05:42:39Z

What problem does this PR solve?

Issue Number: close #42463

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot · 2023-03-22T05:42:41Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

AilinKid
windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

xzhangxian1008 · 2023-03-22T05:43:23Z

/cc @windtalker @AilinKid

ti-chi-bot · 2023-03-22T05:43:25Z

@xzhangxian1008: GitHub didn't allow me to request PR reviews from the following users: Arenatlx.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @windtalker @arenatlx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xzhangxian1008 · 2023-03-22T08:35:35Z

/cc @AilinKid

Defined2014 · 2023-03-23T03:38:01Z

Please fix TestShowBuiltin test

expression/builtin_grouping.go

AilinKid · 2023-03-28T07:22:24Z

you can link your pb pull request here.

xzhangxian1008 · 2023-03-31T03:35:25Z

you can link your pb pull request here.

okk, I have put it on the top field

xzhangxian1008 · 2023-03-31T06:17:22Z

Please fix TestShowBuiltin test

okk

xzhangxian1008 · 2023-04-12T02:47:19Z

/cc @guo-shaoge

windtalker · 2023-04-17T01:48:20Z

DEPS.bzl

@@ -3402,8 +3402,9 @@ def go_deps():
        name = "com_github_pingcap_tipb",
        build_file_proto_mode = "disable_global",
        importpath = "github.com/pingcap/tipb",
-        sum = "h1:CeeMOq1aHPAhXrw4eYXtQRyWOFlbfqK1+3f9Iop4IfU=",
-        version = "v0.0.0-20230310043643-5362260ee6f7",
+        replace = "github.com/pingcap/tipb",


Is the replace = xxxx needed?

Is the replace = xxxx needed?

I will delete it before merge.

expression/builtin_grouping.go

xzhangxian1008 · 2023-04-26T08:51:53Z

/cc @windtalker

expression/builtin.go

expression/builtin_grouping.go

xzhangxian1008 · 2023-04-27T03:15:18Z

/cc @windtalker

windtalker

Others LGTM

windtalker · 2023-04-27T05:19:52Z

expression/builtin_grouping.go

+}
+
+func (b *builtinGroupingImplSig) checkMetadata() error {
+	mode := b.getGroupingMode()


should check isMetaInited first

should check isMetaInited first

okk

xzhangxian1008 · 2023-04-27T06:11:14Z

/retest

AilinKid · 2023-04-27T07:20:29Z

/retest

AilinKid · 2023-04-27T09:28:38Z

/merge

ti-chi-bot · 2023-04-27T09:28:42Z

This pull request has been accepted and is ready to merge.

Commit hash: 7b56e4d

This typo has been introduced via pingcap#42464

xzhangxian1008 added 5 commits March 17, 2023 18:56

save

f88f43d

save

9b1e630

tweaking

bb41467

Merge branch 'master' of https://github.com/pingcap/tidb into grouping

e0c85e2

add tests

011a50d

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 22, 2023

ti-chi-bot requested a review from windtalker March 22, 2023 05:43

ti-chi-bot requested a review from AilinKid March 22, 2023 08:35

Defined2014 mentioned this pull request Mar 23, 2023

unstable test TestShowBuiltin #42467

Closed

AilinKid reviewed Mar 28, 2023

View reviewed changes

expression/builtin_grouping.go Outdated Show resolved Hide resolved

expression/builtin_grouping.go Outdated Show resolved Hide resolved

expression/builtin_grouping.go Outdated Show resolved Hide resolved

expression/builtin_grouping.go Outdated Show resolved Hide resolved

resolve comment

bc417aa

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2023

ti-chi-bot requested a review from guo-shaoge April 12, 2023 02:47

merge

122423a

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2023

windtalker reviewed Apr 17, 2023

View reviewed changes

expression/builtin_grouping.go Outdated Show resolved Hide resolved

xzhangxian1008 added 2 commits April 22, 2023 11:42

Merge branch 'pingcap:master' into grouping

127c91b

resolve comments

8528c43

AilinKid approved these changes Apr 25, 2023

View reviewed changes

xzhangxian1008 added 2 commits April 26, 2023 16:27

address comments"

8b5737e

1

27fecb6

ti-chi-bot bot requested a review from windtalker April 26, 2023 08:51

windtalker reviewed Apr 27, 2023

View reviewed changes

address comments

38ee1fc

ti-chi-bot bot requested a review from windtalker April 27, 2023 03:15

1

9795b97

windtalker approved these changes Apr 27, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2023

xzhangxian1008 added 6 commits April 27, 2023 13:22

tweaking

66aa19a

t

d541996

1

fa8be60

Merge branch 'master' of https://github.com/pingcap/tidb into grouping

5cff8f5

fix

b5e6c32

bazel

e08468d

xzhangxian1008 added 2 commits April 27, 2023 14:17

format

14d75b9

t

c618684

format

7b56e4d

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2023

ti-chi-bot bot merged commit 4e30d7b into pingcap:master Apr 27, 2023

xzhangxian1008 deleted the grouping branch April 27, 2023 10:39

yahonda mentioned this pull request Aug 18, 2023

expression: Replace initialzied with initialized #46208

Merged

12 tasks

yahonda added a commit to yahonda/tidb that referenced this pull request Aug 18, 2023

expression: Replace initialzied with initialized

ec49e41

This typo has been introduced via pingcap#42464

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expression: prepare `grouping` function for `roll up` #42464

expression: prepare `grouping` function for `roll up` #42464

xzhangxian1008 commented Mar 22, 2023 •

edited

Loading

ti-chi-bot commented Mar 22, 2023 •

edited by ti-chi-bot bot

Loading

xzhangxian1008 commented Mar 22, 2023 •

edited

Loading

ti-chi-bot commented Mar 22, 2023

xzhangxian1008 commented Mar 22, 2023

Defined2014 commented Mar 23, 2023 •

edited

Loading

AilinKid commented Mar 28, 2023

xzhangxian1008 commented Mar 31, 2023

xzhangxian1008 commented Mar 31, 2023

xzhangxian1008 commented Apr 12, 2023

windtalker Apr 17, 2023

xzhangxian1008 Apr 22, 2023

xzhangxian1008 commented Apr 26, 2023

xzhangxian1008 commented Apr 27, 2023

windtalker left a comment

windtalker Apr 27, 2023

xzhangxian1008 Apr 27, 2023

xzhangxian1008 commented Apr 27, 2023

AilinKid commented Apr 27, 2023

AilinKid commented Apr 27, 2023

ti-chi-bot bot commented Apr 27, 2023

expression: prepare grouping function for roll up #42464

expression: prepare grouping function for roll up #42464

Conversation

xzhangxian1008 commented Mar 22, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Mar 22, 2023 • edited by ti-chi-bot bot Loading

xzhangxian1008 commented Mar 22, 2023 • edited Loading

ti-chi-bot commented Mar 22, 2023

xzhangxian1008 commented Mar 22, 2023

Defined2014 commented Mar 23, 2023 • edited Loading

AilinKid commented Mar 28, 2023

xzhangxian1008 commented Mar 31, 2023

xzhangxian1008 commented Mar 31, 2023

xzhangxian1008 commented Apr 12, 2023

windtalker Apr 17, 2023

Choose a reason for hiding this comment

xzhangxian1008 Apr 22, 2023

Choose a reason for hiding this comment

xzhangxian1008 commented Apr 26, 2023

xzhangxian1008 commented Apr 27, 2023

windtalker left a comment

Choose a reason for hiding this comment

windtalker Apr 27, 2023

Choose a reason for hiding this comment

xzhangxian1008 Apr 27, 2023

Choose a reason for hiding this comment

xzhangxian1008 commented Apr 27, 2023

AilinKid commented Apr 27, 2023

AilinKid commented Apr 27, 2023

ti-chi-bot bot commented Apr 27, 2023

expression: prepare `grouping` function for `roll up` #42464

expression: prepare `grouping` function for `roll up` #42464

xzhangxian1008 commented Mar 22, 2023 •

edited

Loading

ti-chi-bot commented Mar 22, 2023 •

edited by ti-chi-bot bot

Loading

xzhangxian1008 commented Mar 22, 2023 •

edited

Loading

Defined2014 commented Mar 23, 2023 •

edited

Loading