Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/sqlexec: EscapeSQL support resolve some underlying type #42465

Merged
merged 8 commits into from
Mar 31, 2023
Merged

util/sqlexec: EscapeSQL support resolve some underlying type #42465

merged 8 commits into from
Mar 31, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Mar 22, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Support use customized type whose underlying type is intXXX, uintXXX, floatXX, bool, string in ExecuteSQL. Typically this can make ease of using customized enum type when ExecuteSQL.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

benchmark

at 2137ff3

goos: darwin
goarch: arm64
pkg: github.com/pingcap/tidb/util/sqlexec
BenchmarkEscapeString
BenchmarkEscapeString-8       	 4011201	       292.8 ns/op
BenchmarkUnderlyingString
BenchmarkUnderlyingString-8   	 3403500	       351.3 ns/op
BenchmarkEscapeInt
BenchmarkEscapeInt-8          	 6085053	       196.5 ns/op
BenchmarkUnderlyingInt
BenchmarkUnderlyingInt-8      	 4736172	       253.8 ns/op

at master

goos: darwin
goarch: arm64
pkg: github.com/pingcap/tidb/util/sqlexec
BenchmarkEscapeString
BenchmarkEscapeString-8   	 4089615	       294.3 ns/op
BenchmarkEscapeInt
BenchmarkEscapeInt-8   	 	 6049938	       198.4 ns/op

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
util/sqlexec: EscapeSQL support resolve underlying type
06acd0f 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2023
@lance6716 lance6716 added the skip-issue-check Indicates that a PR no need to check linked issue. label Mar 22, 2023
@lance6716
fix lint
ff42758 
Signed-off-by: lance6716 <lance6716@gmail.com>
xhebox
xhebox reviewed Mar 29, 2023
View reviewed changes
util/sqlexec/utils.go Outdated Show resolved Hide resolved
@lance6716
address comment
faeedb8 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
remove unneeded variables
59fa7ce 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
remove ununsed type in test
300195e 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title util/sqlexec: EscapeSQL support resolve underlying type util/sqlexec: EscapeSQL support resolve some underlying type Mar 30, 2023
@lance6716
add test
568bd33 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
seperate slow path
2137ff3 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 30, 2023
@lance6716
remove unused var
7fbcb62 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2023
GMHDBJD
GMHDBJD approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2023
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7fbcb62

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2023
@ti-chi-bot ti-chi-bot merged commit 2d4df7f into pingcap:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-chi-bot @xhebox @GMHDBJD