Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, executor: support mergeSort for partition tables in IndexLookUp #42483

Merged
merged 16 commits into from
Apr 4, 2023
Merged

planner, executor: support mergeSort for partition tables in IndexLookUp #42483

merged 16 commits into from
Apr 4, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Mar 22, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #26166

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 22, 2023
@Defined2014
Copy link
Contributor Author

/test unit-test

@Defined2014
Copy link
Contributor Author

/test unit-test

@Defined2014
Copy link
Contributor Author

/test unit-test

5 similar comments
@Defined2014
Copy link
Contributor Author

/test unit-test

@Defined2014
Copy link
Contributor Author

/test unit-test

@Defined2014
Copy link
Contributor Author

/test unit-test

@Defined2014
Copy link
Contributor Author

/test unit-test

@Defined2014
Copy link
Contributor Author

/test unit-test

@pingcap pingcap deleted a comment from ti-chi-bot Mar 23, 2023
@pingcap pingcap deleted a comment from ti-chi-bot Mar 23, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 3, 2023
@Defined2014
Copy link
Contributor Author

/test unit-test

@Defined2014
Copy link
Contributor Author

/test unit-test

1 similar comment
@Defined2014
Copy link
Contributor Author

/test unit-test

@Defined2014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5e4c0de

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 3, 2023
@Defined2014
Copy link
Contributor Author

/retest-required

@Defined2014
Copy link
Contributor Author

/retest

@Defined2014
Copy link
Contributor Author

/test unit-test

@hawkingrei
Copy link
Member

/test unit-test

It is a sad story. > 。<

@Defined2014
Copy link
Contributor Author

/test unit-test

It is a sad story. > 。<

😭

@hawkingrei
Copy link
Member

/test all

@Defined2014
Copy link
Contributor Author

/test unit-test

@hawkingrei
Copy link
Member

/retest

2 similar comments
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@Defined2014
Copy link
Contributor Author

/test unit-test

@hawkingrei
Copy link
Member

/retest

1 similar comment
@Defined2014
Copy link
Contributor Author

/retest

@Defined2014
Copy link
Contributor Author

/test unit-test

@Defined2014
Copy link
Contributor Author

/retest-required

@Defined2014
Copy link
Contributor Author

/test unit-test

1 similar comment
@Defined2014
Copy link
Contributor Author

/test unit-test

@ti-chi-bot ti-chi-bot merged commit 2e1522b into pingcap:master Apr 4, 2023
@Defined2014 Defined2014 deleted the mergeSortIndexLookUp branch April 4, 2023 09:14
@ti-chi-bot
Copy link
Member

@Defined2014: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 5e4c0de link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Defined2014 @ti-chi-bot @hawkingrei @tiancaiamao @winoros @XuHuaiyu