Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttl: fix TTL cannot export metrics tidb_server_ttl_phase_time #42517

Merged
merged 1 commit into from
Mar 23, 2023
Merged

ttl: fix TTL cannot export metrics tidb_server_ttl_phase_time #42517

merged 1 commit into from
Mar 23, 2023

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #42515

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manually test steps:

  1. start up a ttl server using this PR:
  2. curl http://127.0.0.1:10080/metrics | grep tidb_server_ttl_phase_time , the metrics output:
# TYPE tidb_server_ttl_phase_time counter
tidb_server_ttl_phase_time{phase="begin_txn",type="delete_worker"} 0
tidb_server_ttl_phase_time{phase="begin_txn",type="scan_worker"} 0
tidb_server_ttl_phase_time{phase="check_ttl",type="delete_worker"} 0
tidb_server_ttl_phase_time{phase="check_ttl",type="scan_worker"} 0
tidb_server_ttl_phase_time{phase="commit_txn",type="delete_worker"} 0
tidb_server_ttl_phase_time{phase="commit_txn",type="scan_worker"} 0
tidb_server_ttl_phase_time{phase="dispatch",type="delete_worker"} 0
tidb_server_ttl_phase_time{phase="dispatch",type="scan_worker"} 0
tidb_server_ttl_phase_time{phase="idle",type="delete_worker"} 1300.1193667450007
tidb_server_ttl_phase_time{phase="idle",type="scan_worker"} 1300.0002689579999
tidb_server_ttl_phase_time{phase="other",type="delete_worker"} 0.0021075060000000007
tidb_server_ttl_phase_time{phase="other",type="scan_worker"} 0
tidb_server_ttl_phase_time{phase="query",type="delete_worker"} 0
tidb_server_ttl_phase_time{phase="query",type="scan_worker"} 0
tidb_server_ttl_phase_time{phase="wait_retry",type="delete_worker"} 0
tidb_server_ttl_phase_time{phase="wait_retry",type="scan_worker"} 0
tidb_server_ttl_phase_time{phase="wait_token",type="delete_worker"} 0
tidb_server_ttl_phase_time{phase="wait_token",type="scan_worker"} 0

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.0 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2023
YangKeao
YangKeao approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2023
bb7133
bb7133 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2023
@bb7133
Copy link
Member

bb7133 commented Mar 23, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8005132

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2023
@lcwangchao
Copy link
Collaborator Author

/retest

1 similar comment
@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot merged commit f5ca27e into pingcap:master Mar 23, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 23, 2023
Merged
4 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #42524.

@lcwangchao lcwangchao deleted the fix_42515 branch March 23, 2023 11:28
ti-chi-bot added a commit that referenced this pull request Mar 24, 2023
@ti-chi-bot
ttl: fix TTL cannot export metrics tidb_server_ttl_phase_time (#42517…
46597f2 
…) (#42524)

close #42515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.0 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ttl: chart in grafana Scan Worker Time By Phase has no data
4 participants
@lcwangchao @ti-chi-bot @bb7133 @YangKeao