-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support pushing down predicates to memory tables in prepared mode (#40262) #42640
planner: support pushing down predicates to memory tables in prepared mode (#40262) #42640
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
17de284
to
4695d0a
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
4695d0a
to
2b1de7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2b1de7e
|
This is an automated cherry-pick of #40262
What problem does this PR solve?
Issue Number: close #39605
Problem Summary:
Predicates are not pushed down to memory tables in the prepared mode because the author avoids doing that intentionally. I'm not sure why but it should work.
What is changed and how it works?
Get the value from constant when it uses prepared mode. Note that it still skips evaluating when DeferredExpr is not nil.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.