Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loaddata: support concurrent writing to TiKV #42667

Merged
merged 6 commits into from
Mar 31, 2023
Merged

loaddata: support concurrent writing to TiKV #42667

merged 6 commits into from
Mar 31, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Mar 29, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #40499

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

a simple test shows concurrent writing improves the performance indeed. tiup playground, 1G data, 4 indexes

  • LOAD DATA thread = 1: 9min 28s
  • lightning default thread = #CPU core: 6min 0s
  • LOAD DATA thread = #CPU core: 4min 52s

however, during the lightning test my OS is very slow, I will deploy a cluster to test it later.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
loaddata: support concurrent writing to TiKV
0e809fd 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 29, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 29, 2023
@lance6716
fix lint
abf4ea4 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix CI
ffe3255 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix stuck
798b2fd 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
add simple test about multi-thread
86d0e61 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/retest

@lance6716 lance6716 changed the title [WIP]loaddata: support concurrent writing to TiKV loaddata: support concurrent writing to TiKV Mar 29, 2023
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2023
@lance6716
Copy link
Contributor Author

/retest

@lance6716
Copy link
Contributor Author

/cc @D3Hunter @GMHDBJD

hawkingrei
hawkingrei reviewed Mar 30, 2023
View reviewed changes
executor/importer/import.go
@@ -300,8 +300,13 @@ func (e *LoadDataController) initFieldParams(plan *plannercore.LoadData) error {
return nil
}

var ignoreInTest = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that it is an atomic type to avoid data race report.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will turn on race check in bazel in next commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8827c5d

D3Hunter
D3Hunter reviewed Mar 31, 2023
View reviewed changes
executor/load_data.go
Comment on lines +113 to +114
encodeWorkers []*encodeWorker
commitWorkers []*commitWorker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer we make encode/commit pair into a chunk worker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to separate commitWorker for future use in @you06 's concurrent INSERT INTO ... SELECT FROM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2023
GMHDBJD
GMHDBJD approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2023
@lance6716
turn on race
8827c5d 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8827c5d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2023
@ti-chi-bot ti-chi-bot merged commit 31a3b2c into pingcap:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @ti-chi-bot @D3Hunter @hawkingrei @GMHDBJD