Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Remove and add partitioning | tidb-test=pr/2125 #42907

Merged
merged 48 commits into from
Aug 18, 2023
Merged

*: Remove and add partitioning | tidb-test=pr/2125 #42907

merged 48 commits into from
Aug 18, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Apr 11, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42616

Problem Summary:

Currently there is no way to partition a non partitioned table or remove partitioning from a partitioned table.
Also there is currently no support for alter a table to a different partitioning scheme.

What is changed and how it works?

Building upon Reorganize Partition, which does all the data copying and recreating the indexes, we can now support ALTER TABLE t REMOVE PARTITIONING and ALTER TABLE t PARTITION BY ...

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Added support for ALTER TABLE t PARTITION BY and ALTER TABLE t REMOVE PARTITIONING

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Apr 11, 2023

/test all

@mjonss mjonss marked this pull request as ready for review April 11, 2023 09:46
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2023
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Aug 1, 2023

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Aug 1, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 10, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bb7133
bb7133 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-07 02:33:12.497981343 +0000 UTC m=+40084.268320046: ☑️ agreed by tiancaiamao.
  • 2023-08-17 11:02:32.270196517 +0000 UTC m=+801716.819212550: ☑️ agreed by bb7133.

@bb7133
Copy link
Member

bb7133 commented Aug 17, 2023

@mjonss Please resolve the conflicts.

@mjonss mjonss removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Aug 17, 2023

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Aug 17, 2023

/test tiprow_fast_test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

@mjonss: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test canary-scan-security
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-br-integration-test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-ddl-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-mysql-connector-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjonss
Copy link
Contributor Author

mjonss commented Aug 17, 2023

/retest

1 similar comment
@mjonss
Copy link
Contributor Author

mjonss commented Aug 17, 2023

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Aug 18, 2023

/retest

@mjonss mjonss removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3e5c751 into pingcap:master Aug 18, 2023
8 of 12 checks passed
@mjonss mjonss deleted the remove-and-add-partitioning branch August 18, 2023 13:22
@mjonss mjonss mentioned this pull request Sep 14, 2023
Merged
15 tasks
@qiancai qiancai mentioned this pull request Sep 21, 2023
Merged
15 tasks
@kennedy8312 kennedy8312 mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ALTER TABLE t REMOVE PARTITIONING
5 participants
@mjonss @ti-chi-bot @hawkingrei @tiancaiamao @bb7133