-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: disable tidb_prefer_broadcast_join_by_exchange_data_size
by default; set scale factor to optimize estimating broadcast join;
#42915
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
tidb_prefer_broadcast_join_by_exchange_data_size
by default; set scale factor for estimating costs of broadcast join;
tidb_prefer_broadcast_join_by_exchange_data_size
by default; set scale factor for estimating costs of broadcast join;tidb_prefer_broadcast_join_by_exchange_data_size
by default; set scale factor to optimize estimating broadcast join;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
/test unit-test |
/merge |
@solotzg: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/assign @qw4990 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e92e91f
|
@solotzg: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #40494 #42961
Problem
In ch-benchmark, tidb will choose the unexpected join method. The estimate row count of
HashJoin_56
is far more bigger than the real one. It may cause the chosen join algorithm(Broadcast Join) is not the best one because the size of hash table when using broadcast join is bigger than the shuffle way, which means it may bring worse performance.What is changed and how it works?
tidb_prefer_broadcast_join_by_exchange_data_size
by defaultBenchmark
ENV
set tidb_prefer_broadcast_join_by_exchange_data_size=ON
TPCH-100 Q9
original
optimized
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.