-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix issue with truncate table and partitions and tiflash (#42957) #43005
ddl: Fix issue with truncate table and partitions and tiflash (#42957) #43005
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@bb7133: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, hawkingrei, mjonss, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #42957
Allocate the table ids at once already in the DDL query session and send them to the ddl worker.
What problem does this PR solve?
Issue Number: close #42940
Problem Summary:
What is changed and how it works?
Check List
Tests
Manual test:
Build the tidb binary
Start a playground cluster with
Run the prepare step:
Wait to the TiFlash replicas are available:
Then just run
truncate table t
over and over again and check the tidb.log for 'handle ddl job failed'Without the fix it comes within a few truncate tables
With the fix it did not show up after 10+ truncate tables
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.