Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: always retry from needRescan when NotLeader #43079

Merged
merged 4 commits into from
Apr 17, 2023
Merged

lightning: always retry from needRescan when NotLeader #43079

merged 4 commits into from
Apr 17, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Apr 15, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43055

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
    without this fix, the newly added UT fails (I added a panic when error is not nil)
panic: write to tikv with no leader returned, region '1', leader: 0

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
lightning: always retry from needRescan when NotLeader
869d353 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 15, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • niubell

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2023
@lance6716
more strict UT
02d39eb 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
remove unused field
313c84a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix lint
28dd9d9 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2023
@lance6716 lance6716 mentioned this pull request Apr 15, 2023
Closed
12 tasks
niubell
niubell approved these changes Apr 15, 2023
View reviewed changes
Copy link
Contributor

@niubell niubell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2023
@lance6716
Copy link
Contributor Author

/run-integration-br-test

@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 28dd9d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2023
@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot merged commit 0c736ce into pingcap:master Apr 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #43084.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 17, 2023
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#43079
b89f83c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 17, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43085.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 17, 2023
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#43079
3c972dd 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@lance6716 lance6716 mentioned this pull request Apr 24, 2023
Merged
12 tasks
@niubell niubell mentioned this pull request May 23, 2023
Open
16 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niubell niubell niubell approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

”write to tikv with no leader returned“ if we meet NotLeader which is caused by on-going schedule
4 participants
@lance6716 @ti-chi-bot @D3Hunter @niubell