Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: refactor checksum to reuse #43082

Merged
merged 6 commits into from
Apr 18, 2023
Merged

lightning: refactor checksum to reuse #43082

merged 6 commits into from
Apr 18, 2023

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #42930

Problem Summary:

What is changed and how it works?

  • move checksum code into separate pkg

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 17, 2023
@D3Hunter D3Hunter changed the title lightning: refactor checksum to reuse part 6 lightning: refactor checksum to reuse Apr 17, 2023
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

D3Hunter
D3Hunter commented Apr 17, 2023
View reviewed changes
br/pkg/lightning/importer/checksum_helper.go Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file named as checksum_helper to make git recongnize local/checksum.go as rename, so less code change

D3Hunter
D3Hunter commented Apr 17, 2023
View reviewed changes
br/pkg/lightning/importer/tidb.go
@@ -234,30 +234,6 @@ func LoadSchemaInfo(
return result, nil
}

// ObtainGCLifeTime obtains the current GC lifetime.
func ObtainGCLifeTime(ctx context.Context, db *sql.DB) (string, error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to checksum.go

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/rerest

@D3Hunter
Copy link
Contributor Author

/retest

2 similar comments
@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

1 similar comment
@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/test mysql-test

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

ci pass https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_integration_br_test/detail/tidb_ghpr_integration_br_test/12532/pipeline

GMHDBJD
GMHDBJD approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2023
@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3876e41

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2023
@hawkingrei
Copy link
Member

/retest

9 similar comments
@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/retest

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot merged commit ab086ae into master Apr 18, 2023
@ti-chi-bot ti-chi-bot deleted the checksum-ld branch April 18, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@okJiang okJiang okJiang approved these changes

@sleepymole sleepymole sleepymole approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@D3Hunter @ti-chi-bot @hawkingrei @sleepymole @okJiang @GMHDBJD